Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(share_plus): #1299 document XFile.fromData #1300

Merged
merged 4 commits into from Oct 29, 2022

Conversation

miquelbeltran
Copy link
Member

Description

Document the use of temporary directories and why developers should care about it.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Document the use of temporary directories and why developers should care about it.
@miquelbeltran
Copy link
Member Author

@Coronon fyi

@Coronon
Copy link
Contributor

Coronon commented Oct 28, 2022

@miquelbeltran Thanks for adding this so quickly :) Just don’t merge yet, you wrote 9getTemporaryDirectory (typo)

@miquelbeltran
Copy link
Member Author

Just don’t merge yet, you wrote 9getTemporaryDirectory (typo)

Thanks! fixed it and added a link to path_provider as well

@Coronon
Copy link
Contributor

Coronon commented Oct 28, 2022

Fabulous 🎉

Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one typo and one possible dot at the end of a sentence - if you like 😊

packages/share_plus/share_plus/README.md Outdated Show resolved Hide resolved
packages/share_plus/share_plus/README.md Outdated Show resolved Hide resolved
miquelbeltran and others added 2 commits October 28, 2022 09:52
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
Co-authored-by: Joachim Nohl <43643339+nohli@users.noreply.github.com>
@miquelbeltran
Copy link
Member Author

Thank you @nohli !

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It seems that the whole Known issues section is missing from our website docs.

@miquelbeltran miquelbeltran merged commit e4a967f into main Oct 29, 2022
@miquelbeltran miquelbeltran deleted the miquelbeltran-patch-1 branch October 29, 2022 15:59
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[share_plus] temporary XFiles directory not cleaned
4 participants