Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share_plus): Show destination for share with result in example, update example UI #1314

Merged
merged 3 commits into from Nov 1, 2022

Conversation

vbuberen
Copy link
Collaborator

Description

Saw that example app for share_plus shows only type of result in case with shareWithResult call, but not the destination. So adding a destination info as well to showcase the feature better for package users.

Additionally decided to give the example app UI a little visual improvement, so made it to use Material 3 and did small changes to make it look more modern and clean to use:

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added the share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin label Oct 31, 2022
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment on a possible improvement

@vbuberen vbuberen enabled auto-merge (squash) November 1, 2022 18:30
@vbuberen vbuberen merged commit e1d3553 into main Nov 1, 2022
@vbuberen vbuberen deleted the update/share_plus_example branch November 1, 2022 18:35
scaffoldMessenger.showSnackBar(getResultSnackBar(shareResult));
}

SnackBar getResultSnackBar(ShareResult result) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants