Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wakeplus disable not working on ios v 16.6 #9

Open
aqueebqazi opened this issue Sep 20, 2023 · 7 comments
Open

wakeplus disable not working on ios v 16.6 #9

aqueebqazi opened this issue Sep 20, 2023 · 7 comments

Comments

@aqueebqazi
Copy link

flutter doctor log
[✓] Flutter (Channel stable, 3.13.0, on macOS 13.5.2 22G91 darwin-arm64, locale en-IN)
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.82.2)
[✓] Connected device (3 available)
[✓] Network resources

! Doctor found issues in 1 category.
Used the following code to test
import 'package:flutter/material.dart';
import 'package:wakelock_plus/wakelock_plus.dart';
void main() {
runApp(const MyApp());
}

class MyApp extends StatelessWidget {
const MyApp({super.key});

// This widget is the root of your application.
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
// This is the theme of your application.
//
// TRY THIS: Try running your application with "flutter run". You'll see
// the application has a blue toolbar. Then, without quitting the app,
// try changing the seedColor in the colorScheme below to Colors.green
// and then invoke "hot reload" (save your changes or press the "hot
// reload" button in a Flutter-supported IDE, or press "r" if you used
// the command line to start the app).
//
// Notice that the counter didn't reset back to zero; the application
// state is not lost during the reload. To reset the state, use hot
// restart instead.
//
// This works for code too, not just values: Most code changes can be
// tested with just a hot reload.
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}

class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});

// This widget is the home page of your application. It is stateful, meaning
// that it has a State object (defined below) that contains fields that affect
// how it looks.

// This class is the configuration for the state. It holds the values (in this
// case the title) provided by the parent (in this case the App widget) and
// used by the build method of the State. Fields in a Widget subclass are
// always marked "final".

final String title;

@OverRide
State createState() => _MyHomePageState();
}

class _MyHomePageState extends State {
int _counter = 0;

void _incrementCounter() {
setState(() {
// This call to setState tells the Flutter framework that something has
// changed in this State, which causes it to rerun the build method below
// so that the display can reflect the updated values. If we changed
// _counter without calling setState(), then the build method would not be
// called again, and so nothing would appear to happen.
_counter++;
});
}

@OverRide
Widget build(BuildContext context) {
// This method is rerun every time setState is called, for instance as done
// by the _incrementCounter method above.
//
// The Flutter framework has been optimized to make rerunning build methods
// fast, so that you can just rebuild anything that needs updating rather
// than having to individually change instances of widgets.
return Scaffold(
appBar: AppBar(
// TRY THIS: Try changing the color here to a specific color (to
// Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
// change color while the other colors stay the same.
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
// Here we take the value from the MyHomePage object that was created by
// the App.build method, and use it to set our appbar title.
title: Text(widget.title),
),
body: Center(
// Center is a layout widget. It takes a single child and positions it
// in the middle of the parent.
child: Column(
// Column is also a layout widget. It takes a list of children and
// arranges them vertically. By default, it sizes itself to fit its
// children horizontally, and tries to be as tall as its parent.
//
// Column has various properties to control how it sizes itself and
// how it positions its children. Here we use mainAxisAlignment to
// center the children vertically; the main axis here is the vertical
// axis because Columns are vertical (the cross axis would be
// horizontal).
//
// TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
// action in the IDE, or press "p" in the console), to see the
// wireframe for each widget.
mainAxisAlignment: MainAxisAlignment.center,
children: [
ElevatedButton(onPressed: ()async{
// bool enable=false;
// Wakelock.toggle(enable: enable);
WakelockPlus.disable();
bool isEnable = await WakelockPlus.enabled;
print("disbaled $isEnable");
}, child: Text("disable")),
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: ()async{
WakelockPlus.enable();
print("enabled");
},
tooltip: 'Increment',
child: const Icon(Icons.add),
),
// This trailing comma makes auto-formatting nicer for build methods.
);
}
}

Using wakelock plus to disable is not working on ios

@diegotori
Copy link
Collaborator

@aqueebqazi please provide a properly formatted reproducible example.

Also, version 1.1.2 was released today, which adds support for package_info_plus version 5.x.x.

Please give that a try first.

@alexandrefresnais
Copy link

I am impacted too. I updated to iOS 16.7.1 and updated wakelock_plus to 1.1.2.

Calling disable after enable does not work, the screen never go to sleep

@dhikshith12
Copy link

I'm using 1.1.3 and calling disable does not work when called after enable, the screen is not going to sleep mode on Android as well.

@Fudal
Copy link

Fudal commented Nov 2, 2023

I have the same problem with new verstion.

@amattsmith
Copy link

I'm having the same issue on iOS 17.1.1 as well. I can successfully enable the wake lock with a button tap, but disabling the wake lock does not seem to work (the device never goes to sleep). I haven't tested other iOS versions yet.

@amattsmith
Copy link

Ok, it works in release mode while not connected to xcode. I was testing and I suspect xcode was keeping it awake as a convenience while connected via the network.

@diegotori
Copy link
Collaborator

@amattsmith that's good to hear. Long term, I might end up doing a couple of things to bring it to modern day iOS practices:

  1. Convert the plugin to Swift.
  2. Use UIApplication.shared.isIdleTimerDisabled to toggle the wakelock, which will bring it in line with how iOS usually does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants