Aggregate errors in uninstall functions #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
uninstall-err
branch
from
9c67b63
to
9944bc3
Compare
hiddeco
force-pushed
the
uninstall-err
branch
from
454287b
to
b0d6832
Compare
stefanprodan
added
the
area/install
stefanprodan
approved these changes
Nov 22, 2022
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
uninstall-err
branch
from
b0d6832
to
b004fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error return value to the uninstall functions. The cli ignores the returned error as it relies on the error message being logged to the user. It is however useful for other programs which want the actual returned error.