build: Pin GitHub Actions #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to add comments with semver, see sigstore/cosign@b7efcb9 |
pjbgf
force-pushed
the
hermetic-actions
branch
3 times, most recently
from
e70a427
to
3b5113a
Compare
|
The comments are not a hard requirement and the official documentation is quite slim on it. My current understanding is that it can be used to pin to a specific semver. I added the comments across external dependencies, apart from the GitHub official actions, which we won't restrict updates to a given semver. |
The main benefit of pinning GitHub actions is the determinism it brings in terms of what version of a given action will be executed. This is a step towards having hermetic builds. Once pinned to a commit, dependabot will automatically issue PRs to update to newer versions. Pinned versions is the only security metric from OpenSSF scorecard that this repository currently have a zero score. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
hermetic-actions
branch
from
3b5113a
to
d0e6fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main benefit of pinning GitHub actions is the determinism it brings in terms of what version of a given action will be executed. This is a step towards having hermetic builds.
Once pinned to a commit, Dependabot will automatically issue PRs to update to newer versions. For the time being this will happen every Monday.
Pinned versions is the only security metric from OpenSSF scorecard that this repository currently have a zero score.
This PR focus on external actions. Flux actions that live in
pkg/actionswill be dealt with separately.