Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label selector flag to get cmd #3764

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add label selector flag to get cmd #3764

merged 1 commit into from
Apr 11, 2023

Conversation

somtochiama
Copy link
Member

This pull request adds a label selector flag to get command to enable users filter objects by label
e.g

flux get sources git -l sharding.fluxcd.io/key=shard1

makkes
makkes approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

cmd/flux/get.go Outdated Show resolved Hide resolved
makkes
makkes reviewed Apr 11, 2023
View reviewed changes
cmd/flux/get.go Outdated Show resolved Hide resolved
@somtochiama
Add label selector flag to get cmd
a52f5aa 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan added enhancement New feature or request area/UX labels Apr 11, 2023
stefanprodan
stefanprodan approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama this will help with sharding 🥇

@stefanprodan stefanprodan merged commit 2dce1f2 into fluxcd:main Apr 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@somtochiama @makkes @stefanprodan