Set priority class for the critical Flux components #3802
Conversation
stefanprodan
added
area/bootstrap
Please see my comment here #3800 (comment) |
| @@ -4,3 +4,6 @@ | |||
| - op: add | |||
| path: /spec/template/spec/serviceAccountName | |||
| value: helm-controller | |||
| - op: add | |||
| path: /spec/template/spec/priorityClassName | |||
| value: system-cluster-critical | |||
There was a problem hiding this comment.
I've been trying to reason about how is this different from setting security context which is set on each of the individual component's deployments.
Priority class seems to be a common thing and not have any dependency on bootstrap related configurations like the service account and events-address that are set above.
I don't see anything wrong, but just wondering how to decide what should be added as a bootstrap patch and what should go to each of the individual component's deployment manifests.
There was a problem hiding this comment.
wondering how to decide what should be added as a bootstrap patch and what should go to each of the individual component's deployment manifests.
I think the deployment manifests in each repo should contain the minimum needed to run the e2e tests. In the future, I really hope to create a dedicated repo for Flux distribution written in cuelang and drop all the kustomize overlays & templating done in the CLI.
Mark source-controller, kustomize-controller and helm-controller as system-cluster-critical. This will reduce the chances of Flux controllers being evicted before other non-critical workloads. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
system-cluster-critical
branch
from
eeec3c9
to
a122ceb
Compare
This PR marks source-controller, kustomize-controller and helm-controller as system-cluster-critical. This priority class will reduce the chances of Flux controllers being evicted before other non-critical workloads and prevents the pods from being permanently unavailable.
Note that this does not prevent evictions, if a node is under pressure, the Flux pods will be evicted before pods marked as
system-node-criticalwhich is the highest available priority.Fixes #3800