Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocompletion for image repository reconcile #3857

Merged
merged 1 commit into from
May 8, 2023

Conversation

talife
Copy link
Contributor

@talife talife commented May 8, 2023

Fix: #3840

Should we start using a completion test routine ?

Signed-off-by: Vincent Gillet <gilletvincent@gmail.com>
@talife talife force-pushed the auto-completion-image-repository branch from ab0a19e to 86df468 Compare May 8, 2023 12:14
@stefanprodan
Copy link
Member

Hey @talife can you please signoff your commit? Instructions here https://github.com/fluxcd/flux2/pull/3857/checks?check_run_id=13311660095

@stefanprodan
Copy link
Member

Should we start using a completion test routine ?

Yes that would be great, please create an issue for this. Thanks!

Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that was an easy one. Thanks @talife!

@stefanprodan stefanprodan merged commit ad3eebc into fluxcd:main May 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-completion for flux reconcile image repository shows ImagePolicies
3 participants