Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent flux install from overriding bootrapped cluster #4345

Merged
merged 1 commit into from Oct 23, 2023
Merged

Prevent flux install from overriding bootrapped cluster #4345

merged 1 commit into from Oct 23, 2023

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Oct 19, 2023 •
edited

This pull request adds a function to get information about the flux installation on a cluster and uses it to check if the cluster has already been bootstrapped to prevent an override when using flux install.

Closes: #4341

stefanprodan
stefanprodan reviewed Oct 19, 2023
View reviewed changes
cmd/flux/install.go Outdated Show resolved Hide resolved
stefanprodan
stefanprodan reviewed Oct 19, 2023
View reviewed changes
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info_test.go Outdated Show resolved Hide resolved
cmd/flux/testdata/cluster_info/gitrepositories.yaml Show resolved Hide resolved
makkes
makkes reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We should incorporate the output of the getFluxClusterInfo into the flux version command, too.

cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/cluster_info.go Outdated Show resolved Hide resolved
cmd/flux/install.go Show resolved Hide resolved
stefanprodan
stefanprodan reviewed Oct 20, 2023
View reviewed changes
cmd/flux/install.go Outdated Show resolved Hide resolved
@somtochiama somtochiama marked this pull request as ready for review October 23, 2023 13:35
@somtochiama
prevent flux install from overriding bootrapped cluster
0eba966 
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan added area/install Install and uninstall related issues and pull requests area/ux In pursuit of a delightful user experience labels Oct 23, 2023
stefanprodan
stefanprodan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama 🥇

@stefanprodan stefanprodan merged commit adc0465 into fluxcd:main Oct 23, 2023
9 checks passed
@kingdonb kingdonb mentioned this pull request Nov 1, 2023
Closed
@stefanprodan stefanprodan mentioned this pull request Nov 16, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/install Install and uninstall related issues and pull requests area/ux In pursuit of a delightful user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent flux install overriding a bootstrapped cluster
3 participants
@somtochiama @makkes @stefanprodan