New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant config drift on webhook rules expansion #792
Comments
I've created a repo to test this: https://github.com/mbrancato/test-knative-serving Some things to help: % flux diff kustomization test-knative-serving --path "./knative-serving" -n default
% flux -n default reconcile ks test-knative-serving
% kubectl describe ks test-knative-serving
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Every time I upgrade Knative, I need to manually expand the webhook rules because on apply, they are modified and no longer match the manifest.
e.g.
https://github.com/knative/serving/blob/25de8121f169719c52e609308f701f45ddba5166/config/core/webhooks/domainmapping-validation.yaml
https://github.com/knative/serving/blob/646d0b1a9626cf636faf3e9b3a58bdd8eeb90ee5/config/core/webhooks/defaulting.yaml
The rules start out like this:
and are modified to this:
I've previously opened issues in other projects without progress:
knative/serving#13449
kubernetes/kubernetes#107318
The text was updated successfully, but these errors were encountered: