Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink what belongs in runtime/controllers #527

Open
hiddeco opened this issue Mar 29, 2023 · 0 comments
Open

Rethink what belongs in runtime/controllers #527

hiddeco opened this issue Mar 29, 2023 · 0 comments
Labels
area/runtime Controller runtime related issues and pull requests enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Mar 29, 2023

Historically, runtime/controllers used to facilitate setting up helpers (to e.g. initialize metrics in a common way for reconcilers to consume).

However, since growing it to support label selectors and rate limit flags. It has become an odd bag of mixed things (and not just "helpers"), which also has overlap with other sub-packages which provide component specific flags like runtime/leaderelection and runtime/client.

Given this, it looks like we need to rethink the structure and move, separate and/or divide (parts of it) to other places.

@hiddeco hiddeco added enhancement New feature or request area/runtime Controller runtime related issues and pull requests labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Controller runtime related issues and pull requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant