Add new package auth for various authentication scenarios
#664
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aryan9600
force-pushed
the
auth-pkg-methods
branch
from
d0dc0ad
to
a1a1d63
Compare
Add package `auth` along with `auth/azure`. The package `auth` will contain authentication related methods and APIs for multiple scenarios. The package `auth/azure` contains an authentication provider for Azure Resource Manager and ACR. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add package `auth/aws` containing an authentication provider for AWS and ECR. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add package `auth/gcp` which contains an authentication provider for GCP Service Accounts and GAR. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add `auth/github` package that contains an authentication provider for GitHub Apps. The provider returns a token to authenticate as a GitHub App installation. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add package `auth/registry` which provides a package level method `GetAuthenticator()` that returns an authenticator for a specific OCI registry. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Add package `auth/git` that provides a package level method `GetCredentials()` which returns credentials to authenticate against a Git provider. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Modify `auth.AuthOptions` to accept a custom cache which takes precedence over the global cache. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
auth-pkg-methods
branch
from
a1a1d63
to
b6693ef
Compare
|
I tried reviewing this but it's hard to review properly with any certainty without any test actually running against the providers. For git, flux2 repo has azure devops and google source repository test infrastructure code. The OCI integration test and flux2 integration test setup are very similar. I think both of them can be combined. I see that this PR resolves #642 . I think there's a lot of things to be done before that can be resolved. Maybe the tests can be in a separate branch against this PR branch. I think running tests against the providers will be very helpful in reviewing these changes properly. Without that, I don't know how to review this without any certainty about the implementation. |
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
auth-pkg-methods
branch
from
8d264b8
to
70ea10f
Compare
|
Is this still planned for the next minor release of flux? I'm looking forward to using this soon if possible to connect to Azure Devops Git. |
Also awaiting this functionality, any updates? |
|
Will this work with the flux bootstrap command when implemented? |
We used to have an Azure account to test all of this but MSFT has canceled our subscription. Also fluxcd/flux2#4544 |
|
I'm just wondering if it would be easier/more manageable if this was broken down a bit? For example it would probably be easier to test GitHub App auth and making related changes to the GitHub provider without worrying about AWS/Azure/GCP mixed in too? Granted I'm a bit biased since I opened fluxcd/flux2#4356 and would love to see it implemented. No worries though and appreciate the effort everyone puts in to make Flux awesome! |
Add a new package
authwhich handles multiple authentication use cases for various cloud providers and SaaS. It inculdes the following sub packages:aws: For AWS and ECR authgcp: For GCP and GAR authazure: For Azure and ACR authgithub: For GitHub Apps authregistry: For OCI registry authgit: For auth against Git providersThe packages
auth/registryandauth/gitalso support caching the authentication credentials viaAuthOptions.CacheOptions.Key. Caching needs to explicitly enabled by either callingauth.InitCache()or specifying a cache viaAuthOptions.CacheOptions.Cache.Fixes #642