Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytekit] Test pytest with --import-mode=importlib #1469

Closed
wild-endeavor opened this issue Sep 13, 2021 · 1 comment
Closed

[flytekit] Test pytest with --import-mode=importlib #1469

wild-endeavor opened this issue Sep 13, 2021 · 1 comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers

Comments

@wild-endeavor
Copy link
Contributor

Describe the bug
See the slack thread. Running pytest with --import-mode=importlib causes tests to fail in certain cases. We should find out why, and fix.

To Reproduce
See slack thread for error. Basically the detection of nested tasks is incorrect when this flag is set.

@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue labels Sep 13, 2021
@eapolinario
Copy link
Contributor

eapolinario commented Sep 14, 2021

Relevant pytest issue: pytest-dev/pytest#7245

I could reproduce the issue in pytest==6.2.5, but not in 6.3.0 which contains pytest-dev/pytest#7870.

There's talk of making importlib the default import mode (as implied by the pytest docs), but it will probably be a while until that happens. In the meantime, it's safe to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

2 participants