Skip to content

Latest commit

 

History

History
29 lines (23 loc) · 1.5 KB

pull_request_template.md

File metadata and controls

29 lines (23 loc) · 1.5 KB
Raw

...ADD PR DETAILS HERE...

PR Checklist

Please leave this checklist in your PR.

  • Source changes maintain stated browser compatibility.
  • Includes updated docs demo bundle if source/docs code was changed (run yarn demo-bundle in your branch and include the /docs/demo-bundle.js file that gets generated in your PR).
  • Issue being fixed is referenced.
  • Unit test coverage added/updated.
  • E2E (i.e. demos) test coverage added/updated.
    • ⚠️ Non-covered demos (look for // TEST MANUALLY comments here) that can't be fully tested in Cypress have been manually verified.
  • Typings added/updated.
  • Changes do not break SSR:
    • Careful to test typeof document/window !== 'undefined' before using it in code that gets executed on load.
  • README updated (API changes, instructions, etc.).
  • Changes to dependencies explained.
  • Changeset added (run yarn changeset locally to add one, and follow the prompts).
    • EXCEPTION: A Changeset is not required if the change does not affect any of the source files that produce the package bundle. For example, demo changes, tooling changes, test updates, or a new dev-only dependency to run tests more efficiently should not have a Changeset since it will not affect package consumers.