-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration option loader is ignored when type: "transform" #27
Comments
I thought that should work too, but I'll have a look. It's probably bailing out before the transform method is called with your custom loader config. I'll have a look! |
Sorry, I should have RTFM: Looks like I believe it's this feature causing my issue, not your implementation.
I think this issue can be closed now. I do still have the issue of losing code coverage reporting ( |
@folke running into the same thing wanting to transform code that does an import on a @karrikuivanen is right that for transform mode, there can only be one loader at a time (because there is one transform happening per file) The list of "entry file" loaders is hardcoded here. What was the reason to comment out ".css"? Line 41 in 1d38dd4
Additionally, I understand that there is a check to prevent sources in I don't have a strong opinion or suggestion, mainly sharing findings, but maybe be albe to fully configure the transform loaders including include/exclude? For now I'll deal differently with this single .css file, transforming/importing just TS worked perfectly fine with esr. |
Have you tried configuring it with the |
@marcelbeumer the reason we dont transpile sources under tbh honest, I don't remember the exact reason why I didn't inlcude the css loader. Probably because I ran into an issue with some code. I'm happy to add it as a default again. |
Yes I tried with the loader option, but it didn't work, I think because here only the hardcoded loaders are wired? Line 48 in 1d38dd4
It works when I uncomment the |
Right, I know what's happening here. I'll work on a fix! |
Let me know if it helps to create a separate reproducible test case (esbuild vs esr bundle vs esr transform) |
Messages crossed. Thanks! |
Hi. Is fix still coming? |
Hi,
I noticed having
type: 'bundle'
in my esbuild-runner config broke my test coverage, so swapped it out to"transform"
.This, however, caused my
loader
definition to be ignored.Would it be possible to give
type: 'transform'
the same love you gave tobundle
in #24 ?Thanks!
The text was updated successfully, but these errors were encountered: