Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale all glyphs #16

Open
fonsecapeter opened this issue May 13, 2019 · 2 comments
Open

Rescale all glyphs #16

fonsecapeter opened this issue May 13, 2019 · 2 comments
Assignees

Comments

@fonsecapeter
Copy link
Owner

This is a pretty big lift, but basically the vertical metrics are a little off (rookie mistake). They're correct in a world without accented capital letters, but with them, certain renderers can clip, for example the top of the accent in Á. To fix this, all letters will need to be scaled down relative to the viewport in Inkscape. The vertical metrics will also need some adjusting based on where the x-height / cap-height ends up and whatnot. May need to narrow up the width proportionally too to keep the letters spaced the same.

This won't just be for the sake of accented capital letters too, terminal highlighting should come out looking better after this change too. As seen in this vim-airline screenshot, the highlighting seems too low relative to the letters:

Screen Shot 2019-05-13 at 3.08.17 PM.png

And my terminal block cursor looks wrong in the same way:

Screen Shot 2019-05-13 at 3.09.45 PM.png

Have to check, but pretty sure the descent is a bit on the large side (200) because there just was extra space there, so might be able to translate the whole viewport upward, but it likely won't be enough so probably have to still do some scaling down of everything.

@fonsecapeter fonsecapeter self-assigned this May 13, 2019
@fonsecapeter
Copy link
Owner Author

Not 100% necessary for this epic since it's possible to get fontbakery to pass in this state, but probably a good idea to sort out before a wide release

@fonsecapeter
Copy link
Owner Author

Have imporoved this in #5 but this is still sort of a thing in v1.000. Google updated their requirements to require a 1200 EM square instead of the old 1000 style that I used. This will change things a bit and I'll likely just add the extra 200 on top to account for capital diacritics. Don't want too much empty space between lines though so will play around with this and see what ends up looking best in the new 1200 space

Screenshot 2023-10-05 at 10 55 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant