-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(URGENT) Crashes in Fontist on GHA #367
Comments
@alexeymorozov can you please help with this? Thanks. |
Working on it. I found out which formula fails (google/space_mono) and that Google Fonts started to use the javascript redirection for downloads which are not handled in Curl for Space Mono returns the 200 OK status code but its content is the javascript redirection:
|
Temporarily as a hotfix and a test case I've replaced the current formula with 4 others for each style with urls which the site uses. I've tried and it works in my fork. The fix is already in the formulas repo so the opengeospatial's repo should work too now. But we need a proper fix because, as far as I see, all google formulas stopped working. The current archive URL returns javascript which calls API and gets urls for each font style, then downloads them and archives in a zip file after. API with urls for styles: https://fonts.google.com/download/list?family=Space+Mono More information on the Google's change: google/fonts#7481 How people are dealing with the change: squidfunk/mkdocs-material#6983 |
@alexeymorozov I think we have two problems to deal with:
For 1, the best choice has to be directly parsing the google/fonts GitHub repository. Changes there may be more frequent than their new Developer API, but also means we can respond to them faster. It would mean we need to parse font metadata ourselves, but that's also reasonable because we need that functionality for fonts sourced outside of Google Fonts. For 2, users have two needs with Google Fonts:
Conclusion:
Regarding 1: Interestingly, their metadata file ( Except that they have:
They also have Maybe having this information would also be a good choice for Fontist... |
From @ghobona at metanorma/metanorma-ogc#651
Error 1:
Error 2:
The text was updated successfully, but these errors were encountered: