Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Grammar mode through npm #14

Open
Nexucis opened this issue Mar 15, 2020 · 6 comments
Open

Getting Grammar mode through npm #14

Nexucis opened this issue Mar 15, 2020 · 6 comments

Comments

@Nexucis
Copy link

Nexucis commented Mar 15, 2020

Hello,

Would you considere to provide this library as a npm package ?
It will be great to be able to do that, because it makes it difficult to use it when you are going use it through an angular/react application for example.

Thanks :).

@foo123
Copy link
Owner

foo123 commented Mar 15, 2020

This is an option I am considering for many of my open-source projects. The most important part is dependency handling which npm can handle better, but as an alternative untill I set up an npm account is to simply try to put the code in as a local dependency (for example https://stackoverflow.com/questions/15806241/how-to-specify-local-modules-as-npm-package-dependencies).

I leave this issue open to remind me to do take care of that.
Thanks

@Nexucis
Copy link
Author

Nexucis commented Mar 15, 2020

Cool !
Thanks for the news.
Do you need any help for that ? And another things, do you consider it will be a nice idea to move to typescript as well ?

@foo123
Copy link
Owner

foo123 commented Mar 15, 2020

I dont use typescript, I dont have a case where I need it, plain javascript is fine, as far as I can eliminate any unnecesary internediate/compilation step I am happy. If and when I have a use case where typescript is certainly needed I will certainly make use of it. In any case typescript is only syntactic sugar on top of plain js.

Help is a good idea as I have many projects and time is limited. I will keep it in mind. Thanks.

@Nexucis
Copy link
Author

Nexucis commented Mar 15, 2020

Well maybe on your side, you don't need to use typescript.
But consider that you are exposing a library and
moving to typescript will make people (like me) to use it in Angular/React in an easy way, because well for Angular at least you don't have the choice, you have to code in Typescript.
So it's another argument to make your library easier to use/import and so one :)

@foo123
Copy link
Owner

foo123 commented Mar 15, 2020

This is a valid point. Even though 3rd-party libs dont have to be coded in typescript to work inside another project. It is simply vanilla js, it works.

I dont dismiss it but even though I prefer plain js myself as far as possible, it is a long task to transform all this code to typescript. fI someone wants to undertake the task, it is fine with me.

This is not something I plan for the near future. NPM integration is possible in the near future. Typescript recoding no.

@foo123
Copy link
Owner

foo123 commented Apr 28, 2020

Please see comments on this pull request and suggestions to quickly resolve your problem untill I make these adjustments myself some time in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants