Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 checklist #83

Open
1 of 4 tasks
tabatkins opened this issue Jun 8, 2021 · 3 comments
Open
1 of 4 tasks

v1 checklist #83

tabatkins opened this issue Jun 8, 2021 · 3 comments

Comments

@tabatkins
Copy link
Collaborator

  • spec-test-bot can check spec commits for WPT links, and create a Commit Check from it
    • it checks all the WPT link variants (tracked in an inline TODO)
  • stb can be talked to, to tell it to forget a WPT link it erroneously grabbed, or to give it a WPT link when the commit message forgot to list one
    • stb can update the Check accordingly
@foolip
Copy link
Owner

foolip commented Jun 8, 2021

While GitHub Checks are always against a commit SHA, there are two different kinds of checks we could do, PR checks and commit checks. Should both of those be considered v1? It sort of depends on where we think this will be tried out first.

@tabatkins
Copy link
Collaborator Author

Yeah, if I'm going to try and connect it to CSSWG, we do most of our work outside of PRs, so the commit check is more useful. We def want to do PRs as well, but we want to then automatically pass the commit checks when the PR is merged, if the PR checks passed. That'll need the db backing.

So if v1 doesn't include the db, then I think we need to decide between commit and PR checks for now, and not do both.

@foolip
Copy link
Owner

foolip commented Jun 9, 2021

So I'm thinking let's do only commit checks as a starting point then, that's more low-level than PRs and likely will result in reusable building blocks for PRs later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants