Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey for Add Bookmark in-place #1153

Open
Kyliathy opened this issue Sep 18, 2020 · 2 comments
Open

Hotkey for Add Bookmark in-place #1153

Kyliathy opened this issue Sep 18, 2020 · 2 comments

Comments

@Kyliathy
Copy link

Hello :). Thank you for the wonderful work you've done with this extension! It really eases my life when it comes to adding bookmarks in a particular folder, since the way you're displaying them is way better than the default.

I would like to also use your extension for adding bookmarks! :). Currently, as you know, the Hotkey in Chrome is CTRL + D and then ENTER to add the bookmark somewhere. I have configured your extension to show up at CTRL + ALT + D. However, the default action in your extension for ENTER is to open a bookmark.

So then how about making CTRL + ENTER a shortcut for ADDING the current page? It is slightly cumbersome that every time I need to add a bookmark I have to RIGHT CLICK, then select a TINY option (Add Current Page) from a tiny menu :)

This is slightly related to a different reported issue (adding hotkeys inside the extension).
#1036

@foray1010
Copy link
Owner

Does following solution satisfy your use case?

  1. Use Cmd + D (Ctrl + D for Windows) to add bookmark
  2. After open the extension, press arrow up/down to select the bookmark that you wanna create bookmark under it > Ctrl in Mac or Menu key in Windows > arrow up to select Add current page

@Kyliathy
Copy link
Author

Kyliathy commented Sep 23, 2020

Hey! :). Thanks for answering 👍

Actually, I realized there's another issue. You can't open folders with ENTER. So even if I open the extension, I can't navigate in it with my keyboard. I'm a keyboard power-user, so preferably, the ENTER key would allow me to enter a folder (in the extension's case, also move the focus to the newly opened panel with the folders inside that folder).

Then CTRL + ENTER would immediately add the bookmark in the current folder :).

Another impediment in using the extension for adding bookmarks is that the search doesn't do folders, just bookmarks. Of course, it depends on you if you want to make the extension good for just viewing or also for adding. I think it's not going to be that difficult really :). Just some small UX tweaks and you're done.

What I'd recommend is this:

  • Have 2 different hotkeys to open the extension: VIEW and ADD (I've seen that some extensions support multiple hotkeys).
  • In the ADD mode, the search should search FOLDERS instead of bookmarks. You can see how extremely efficient this can get in the extension Fast Bookmarks, which I'm currently using to circumvent the fact that Popup My Bookmarks is not so effective when creating bookmarks.

And that's it :). If you implement a different shortcut that lists folders instead of bookmarks, then one can simply use arrows to select a folder and simply ENTER to add ;)

Honestly I'd even contribute myself to coding such a feature :). I think your extension is quite complete. Would be lovely to handle everything there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants