Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chokidar - macOS fixes #195

Open
mririgoyen opened this issue Aug 31, 2020 · 6 comments · May be fixed by #198
Open

Update chokidar - macOS fixes #195

mririgoyen opened this issue Aug 31, 2020 · 6 comments · May be fixed by #198

Comments

@mririgoyen
Copy link

Please consider updating chokidar to the latest version (this library is a full major version behind). They have just fixed several issues around macOS and Docker that would improve file watching.

@kibertoad
Copy link
Contributor

@goyney AFAIR, main reason behind that was chokidar dropping compatibility with Node 6 in the major release. Considering that forever is run on legacy systems first and foremost, we have to be very conservative about dropping support for even old Node.js versions.

@kibertoad
Copy link
Contributor

Double-checked - yup, 3.0.0 is Node 8+-only

@mririgoyen
Copy link
Author

mririgoyen commented Aug 31, 2020

I mean, that is what semver is for. Those instances wouldn't update? Seems like this could be a major version bump.

EDIT: Also, consider https://nodejs.org/en/about/releases/. Node 6/8 aren't LTS anymore.

@kibertoad
Copy link
Contributor

@goyney That is true. However, that would mean that those older instances will stop receiving any fixes at all, unless someone backports them, and doing any changes in forever is painful already.
Many systems that are running forever are using deprecated Node versions. Even when we dropped Node 4 there were complaints from users.

Check these statistics:
https://nodejs.org/metrics/summaries/version.csv
https://nodejs.org/metrics/summaries/version.png

Node 6 is still very much a thing (even though personally I would very much preferred if it wasn't)
In general forever is mostly a legacy software, meant for legacy systems, currently on life-support. For newer systems using pm2 or nodemon is a much better option.

@Hypnosphi
Copy link

FYI here's an NPM warning on clean install:

npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.

Here's how babel plans to deal with it without dropping node 6 support: babel/babel#11560

@kibertoad
Copy link
Contributor

@Hypnosphi OK, this is pretty smart. Would you be open to submitting a PR implementing the babel solution?

@Hypnosphi Hypnosphi linked a pull request Nov 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants