-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package is deprecated #31
Comments
Really ? Because I just installed this plugin so that folds are rembered. |
@solsticedhiver Hmm... Are you using tree sitter parsers ( |
@binaryfunt oh in fact it seems to work after all. sorry Edit: |
Do either of you know if there's a way to mark a package as deprecated in the atom package registry? I've switched to vscode, so my knowledge on atom packages, and where to even look in the docs isn't up to date. |
Yeah, the native remembering is not perfect unfortunately. However, it seems like this package might conflict with the current versions of Atom (#30) |
@forivall From what I can tell, you might have to submit a pull request asking for it to be marked as deprecated (https://discuss.atom.io/t/how-to-mark-a-package-as-deprecated/34745/3). I don't know if this works but it's also possible to set a maximum version of Atom in the package.json "engines": {
"atom": ">=1.0.0 <2.0.0"
} I guess a simpler/safer option may be to just warn people in the package description line. |
Has anyone gotten fold-saving to work on native Atom? For me it doesn't seem to be possible, and as has been mentioned, this package no longer works with the latest Atom |
I've received reports that it does work natively (requiring tree-sitter enabled), and I was working on making a nice tool to mark this as deprecated. Can anyone who's actively using atom comment? (as i'm not actively using atom) |
I just tested this with From my testing (with and without tree-sitter), Atom natively remembers folding for closed windows, but if a single file tab is closed and reopened, it doesn't remember the folds. So this package still has an advantage over how atom handles things. |
Thanks for the info Milan! Closing this out. |
Atom now remembers folds natively (as of v1.35.0 at least).
The text was updated successfully, but these errors were encountered: