-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if formData
hash values are not strings, to prevent source.on is not a function
#321
Comments
Yeah, looks like legit issue. Do you mind to create a PR? Thank you |
@alexindigo That was four months ago. I'm not using the library anymore... |
Ok. I'll close this issue then. :) Thanks. |
Why would you close an issue without a solution? |
You said, you're no longer interested in this issue. So it was logical to close it. |
I meant that I can't really make a pull request for it. It's still an issue potentially to a lot of people, even if they don't complain about it. It's an instance where the code doesn't check its inputs, which is a defect. |
I'd suggest leaving it open so we can track the defect. |
Ok. |
Thanks @alexindigo! |
I'll take a look at this when we do #137. |
Also, specifically for converting objects to use formdata syntax see q-flat. |
In request/request#1495, the example code gets an error like
source.on is not a function
because one of the values in theformData
has for arequest
orrequest-promise
options hash is not a string.The
form-data
module should detect this error and tell the user to ensure allformdata
hash values are strings, orwriteStreams
, or whatever else is valid.The text was updated successfully, but these errors were encountered: