Move @types/react from deps to devDeps

[kyriiherman]

Which package?

react-intl

Describe the bug

I use react v16 so I don't need @types/react v17 in my node_modules. And since react-intl is compatible with react v16 and v17 I think it's not a problem to move it to devDeps.

[longlho]

is this causing a compilation issue?

[kyriiherman]

Yes, I have types/react@16 the the root of node_modules and there is a bug in TS that in such cases I have to set the path to types explicitly in tsconfig if these types are not in the node_modules/@types folder

[longlho]

do you have a codesandbox?

[kyriiherman]

No, this problem can't be reproduced in code sandbox, but I found an original issue: microsoft/TypeScript#42873.
Do you need typings for React@17 in dependencies for any reason?

[longlho]

Yeah we rely on react types for a bunch of stuff

[kyriiherman]

I mean why these types can't be moved to devDependencies? And according to package.json react-intl can be used with react@16 as well:

formatjs/packages/react-intl/package.json

Line 143 in c4d2f6a

"react": "^16.3.0 || 17",

[longlho]

because if you use TS and you use react-intl, we reference react types