Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project should declare extra dependency on dnspython #128

Open
jaraco opened this issue May 31, 2017 · 0 comments
Open

Project should declare extra dependency on dnspython #128

jaraco opened this issue May 31, 2017 · 0 comments

Comments

@jaraco
Copy link
Contributor

jaraco commented May 31, 2017

As I was working through the dependencies for Formencode, I discovered that the dependency for DNS has changed over time, but has been undeclared except in documentation.

It would be better if Formencode could declare its dependency in the package metadata using 'extras'. I suggest the extra name 'DNS' or 'dns', such that if a package requires FormEncode with the DNS validation functionality, it will require formencode[dns], and thereby rely on FormEncode to declare its dependency on the necessary libraries to support the DNS validation.

In this way, the client packages won't need to themselves monitor and maintain the dependency declaration for the package which is otherwise only used by FormEncode.

Any reason you wouldn't accept a PR to this end?

Also, I note that the tests currently rely on dnspython or dnspython3 depending on the version of Python used. Is that the recommended configuration or is dnspython 1.3, which supports Python 3.3+, suitable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant