Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Validation doesn't work! #6

Open
mohammedzamakhan opened this issue Dec 9, 2016 · 2 comments
Open

Validation doesn't work! #6

mohammedzamakhan opened this issue Dec 9, 2016 · 2 comments
Labels

Comments

@mohammedzamakhan
Copy link
Collaborator

I tried adding validation, by adding validators and validationMessages for required on FormlyModule.forRoot, and then I had required: true to a field, but it didn't seem working

@NathanWalker
Copy link
Contributor

NathanWalker commented Dec 10, 2016

@mohammedzamakhan Yep at this point it's a proof of concept. Thanks for tracking this, definitely a TODO.

Btw, the structure of the code right now includes the same code as the initial library, however much can be shared, therefore we will probably remove a lot of that code from here and only provide the modified services necessary to provide the NativeScript specific functionality.

For instance, these files can all be used as-is straight from the original lib; they can just be imported from the installed orig lib. They are duped here at the moment just to develop things out, but a final step would be to remove all code that is untouched and use those directly from the orig lib. Just stating for other contributors understanding.

I wanted to kick off this development with this POC. Holidays are busy time for me so don't have a timeline to completion at moment but look forward to when that happens; it's a great lib and having it for {N} apps just makes it that much sweeter 👍

@mohammedzamakhan
Copy link
Collaborator Author

I am loving NativeScript platform too now. When I created to work on Angular 2 support, I knew that this could be supported for NativeScript, but did not have time to learn it and develop it. You have been a great help for it, and the POC looks clean and smooth.

Let me know if you need any help, will be always open to any new suggestions for the whole library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants