Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify "card" logic #88

Open
TylerVigario opened this issue May 4, 2023 · 0 comments
Open

Simplify "card" logic #88

TylerVigario opened this issue May 4, 2023 · 0 comments
Assignees
@TylerVigario

Comments

@TylerVigario
Copy link
Collaborator

TylerVigario commented May 4, 2023 •
edited

My goal was to break splitNum into smaller (defined) functions that are easy to understand. However, the attempts I've committed have significant issues to resolve before we can merge them.

After many attempts, I realize two significant developer hurdles you overcame:

  1. Matching the highest value card creates a new number to match (nested processing) (i.e., 563 "thousand" for 563000)
  2. Languages can have special requirements for joining cardinal words

To speed up this PR, I will delay those logic changes (to a different PR) until further discussion.

Originally posted by @TylerVigario in #85 (comment)
@TylerVigario TylerVigario self-assigned this May 5, 2023
@TylerVigario TylerVigario changed the title [Improvement] Simplify "card" logic Simplify "card" logic May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerVigario TylerVigario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerVigario