Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send slack notification #14

Open
kodai305 opened this issue Jun 22, 2021 · 1 comment
Open

Don't send slack notification #14

kodai305 opened this issue Jun 22, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kodai305
Copy link

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. npm install -g amplify-category-console-notification
  2. amplify plugin scan
  3. amplify console-notification add
  4. amplify push
  5. push repository and build start

Expected behavior
send slack notification

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • npm: 7.11.1
  • amplify: 5.0.1
@kodai305 kodai305 added the bug Something isn't working label Jun 22, 2021
@fossamagna fossamagna self-assigned this Jun 22, 2021
@fossamagna
Copy link
Owner

@kodai305 Thanks for the feedback.
Now, We have a restriction that branch name and environment name must be same.
If you use different names for the branch name and the environment name, there will be no notification to slack.

I will address this issue. I'm going to add the ability to specify the branch name in amplify-cli update command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants