Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement on/off buttons for Include, Required and Public #18

Open
mariobehling opened this issue Jan 19, 2024 · 10 comments
Open

Implement on/off buttons for Include, Required and Public #18

mariobehling opened this issue Jan 19, 2024 · 10 comments

Comments

@mariobehling
Copy link
Member

Problem and impact

Forms choices on the organiser view seem a bit confusing with the text explaining what they do.
Instead implement “on/off buttons” for a) Include b) Required and c) Public.

Screenshot from 2024-01-19 18-33-29

See below. We need a similar implementation

Screenshot from 2024-01-19 18-37-59

Proposed solution / feature

No response

Context or examples

No response

@mariobehling mariobehling transferred this issue from mariobehling/Xoai-Artwork Jan 22, 2024
@themonster2015
Copy link

Hey, can I work on this feature?

@mariobehling
Copy link
Member Author

Yes, please go ahead.

@cbum-dev
Copy link

cbum-dev commented Mar 8, 2024

Screenshot from 2024-03-08 12-57-08
Do i need to put those buttons in the same line?

@cbum-dev
Copy link

cbum-dev commented Mar 8, 2024

Screenshot from 2024-03-08 20-22-44
I was walking through the code but i haven't got these togglers. Do i have to create a new one or is there any other way ?

@mariobehling
Copy link
Member Author

These are just examples. Something along those lines is fine. It does not have to be exact.

@cbum-dev
Copy link

Screenshot from 2024-03-19 13-55-21

@mariobehling
Copy link
Member Author

Looks nice!

Two things:

  1. There is a problem with the issue description I have created, because it leaves out an important point:

The input validation has three options instead of only two (see screenshot below). Therefore a simple switch button is actually not possible. A switch button with three options would be best. I am not sure if this can be implemented easily or do you have another suggestion?

  • always optional
  • always required
  • required after a deadline
    Screenshot from 2024-03-19 11-38-33
  1. Any chance to add "Show public"?
    The user can already define that option when creating or editing a question. So, the logic already exists in the system.
    Screenshot from 2024-03-19 11-37-12

@cbum-dev
Copy link

Looks nice!

Two things:

1. There is a problem with the issue description I have created, because it leaves out an important point:

The input validation has three options instead of only two (see screenshot below). Therefore a simple switch button is actually not possible. A switch button with three options would be best. I am not sure if this can be implemented easily or do you have another suggestion?

* always optional

* always required

* required after a deadline
  ![Screenshot from 2024-03-19 11-38-33](https://private-user-images.githubusercontent.com/1583873/314021031-c2a84167-7103-4714-a5dc-489c57a2535a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA4NDUzODgsIm5iZiI6MTcxMDg0NTA4OCwicGF0aCI6Ii8xNTgzODczLzMxNDAyMTAzMS1jMmE4NDE2Ny03MTAzLTQ3MTQtYTVkYy00ODljNTdhMjUzNWEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTlUMTA0NDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWZhMDE5NjAwNjY3YzM2MjFjMDNjZjM0NTQ1YjQyNDY1NmUyOWIxODBmNTlmNzMyMmRiOWM3NzBjNDhlOGY5MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.S_cu7qicPmX0edEazlP70KttFBxNl2MlWyVH-7lzOM0)


2. Any chance to add "Show public"?
   The user can already define that option when creating or editing a question. So, the logic already exists in the system.
   ![Screenshot from 2024-03-19 11-37-12](https://private-user-images.githubusercontent.com/1583873/314021385-ae45d053-b4c2-48ae-a0ee-df7b2afc1367.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA4NDUzODgsIm5iZiI6MTcxMDg0NTA4OCwicGF0aCI6Ii8xNTgzODczLzMxNDAyMTM4NS1hZTQ1ZDA1My1iNGMyLTQ4YWUtYTBlZS1kZjdiMmFmYzEzNjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMTlUMTA0NDQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTk5NTgxNzQ5ZjIyM2YyNTllNTdiMDM2MWNmM2RlOTQ2ZGQyMWYwZmY4ODI0ZTExOWRkZTczNTNiYmI5M2IwMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Y07O3iGFVwtk3l6i9NiwjPozbxBZLxrzFEa_DRECPhk)

I was too thinking the same for required section. I will surely think some alternative for three options.
For show public I'll add another toggle button for that.

@cbum-dev
Copy link

cbum-dev commented Mar 20, 2024

Screenshot from 2024-03-20 19-16-07
Here I have added a toggling feature with each click it will toggle between all of them, but when user wants to choose the "Required after a deadline option" it will redirect to the edit page to set the time.
Is it good or I should add three buttons/radio buttons side by side ?

@mariobehling
Copy link
Member Author

Thank you. I think the team needs to test this practically. It sounds feasible so far. Please make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants