Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Bumped up python version #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Bumped up python version #36

wants to merge 4 commits into from

Conversation

elle-Bee
Copy link

Fixes #33

  • Updated the workflow matrix in tests.yml to use [3.7, 3.10, 3.11] instead of [3.6, 3.7, 3.8].

  • Updated PostgreSQL version 9.5 -> 11 in /doc/admin/installation

NaviRocker
NaviRocker approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@NaviRocker NaviRocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go!

@hongquan
Copy link
Member

Please remove support for v3.7 also. We will support v3.10 onward.
The tactics is to support the Python included in the latest Ubuntu LTS. At the time of writing this, latest Ubuntu LTS is Ubuntu 22.04, and it comes with Python v3.10.

hongquan
hongquan requested changes Feb 15, 2024
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@elle-Bee
Copy link
Author

Made the changes now it only refers to versions 3.10 and 3.11

@elle-Bee elle-Bee requested a review from hongquan March 5, 2024 14:04
@hongquan
Copy link
Member

hongquan commented Mar 6, 2024

I am sorry, @elle-Bee. Because the current codebase of eventyay-tickets is depending on very old libraries, I'm not sure if they are really compatible with Python v3.10+, especially libraries which are written in C/C++. So I have to hold your PR in pending until another task, which is to upgrade Django, finishes. The other task will involve upgrading dependencies as well, and help us test this PR easier.

@hongquan hongquan changed the title Bumped up python version [WIP] Bumped up python version Mar 6, 2024
@hongquan hongquan mentioned this pull request Mar 11, 2024
Open
@hongquan
Copy link
Member

Could you work on another task to remove Python 3.6, 3.7 from GitHub Action script?

@marcoag marcoag force-pushed the master branch 2 times, most recently from 7bcd24e to 3633a5b Compare April 19, 2024 18:13
@hongquan
Copy link
Member

Please resolve conflict @elle-Bee

@elle-Bee
Copy link
Author

resolved the conflicts with the dockerfile

@elle-Bee
Copy link
Author

hey @hongquan any updates?

@mariobehling
Copy link
Member

The Python upgrade can only be done as part of the Django system upgrade. The build does not work with the updates in this issue currently.

@elle-Bee
Copy link
Author

oh okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaviRocker NaviRocker NaviRocker approved these changes

@hongquan hongquan Awaiting requested review from hongquan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump project to Python 3.11
4 participants
@elle-Bee @hongquan @mariobehling @NaviRocker