Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the unique ticket code into the downlad CSV file #9129

Closed

Conversation

Shivangi-ch
Copy link

Fixes #9127

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@Shivangi-ch
Copy link
Author

@mariobehling after analysing the code I found that, what we see in the order column in csv is the order invoice number['O' + created_at_time + '-' + order.id(primary key)].
Where as in the ticket holder qr code we have [order.identifier + '-' + ticket holder.id(primary key)].
And in the first screenshot order colums it is order.identifier
And for the ticket Id we only have the primary key field 'id'.

I have added order.identifier as the ticket id in the csv now... pls confirm if it is the right value for this!

@Shivangi-ch
Copy link
Author

Closing this pull request as the issue has been resolved by another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the unique ticket code into the downlad CSV file
1 participant