Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Recording start even when device not connected #2093

Open
dheerajkotwani opened this issue Jan 26, 2020 · 7 comments
Open

bug: Recording start even when device not connected #2093

dheerajkotwani opened this issue Jan 26, 2020 · 7 comments
Labels
Bug Unexpected problem or unintended behavior in app Codeheat

Comments

@dheerajkotwani
Copy link
Member

Actual Behaviour
Recording can be started even if the device is not connected to mobile or mobile does not have inbuilt feature support

Expected Behaviour
If any device is not connected then for that device recording should not start

Steps to reproduce it
Open any device which is not connected or whose sensor are not present in mobile(Gas Sensor)
Click on Record button
See the error

Screenshots of the issue
recording_issue

Would you like to work on the issue?
Yes

@mariobehling
Copy link
Member

Expected behavior would be a pop up "Please connect a device or choose an phone sensor (if available)" and two buttons "Configure Active Sensor" and "Cancel".

@mariobehling mariobehling added the Bug Unexpected problem or unintended behavior in app label Feb 3, 2020
@mariobehling
Copy link
Member

In sensors that are usually present on the phone the recording should work nevertheless.

@SpandanBasu
Copy link

I am a beginner. I want to work on this issue please assign me

@SpandanBasu
Copy link

When the sensor is not present and the user clicks on the recording button, A pop-up dialog comes..right..but on pressing on Configure active sensor where should the app take the user?

@sambhavsaxena
Copy link

Please assign this issue to me

@SpandanBasu
Copy link

This issue is already fixed i opened a pull request. Try a different issue. Thanks

@shubham-200315
Copy link

Hey @mariobehling , Issue is fixed and PR is merged already so i think we can close this.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior in app Codeheat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants