Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscilloscope: After selecting PSLab MIC, In-Built-MIC does not work when PSLab device is not connected #2173

Closed
arpoch opened this issue Jan 20, 2021 · 3 comments

Comments

@arpoch
Copy link

arpoch commented Jan 20, 2021

Actual Behaviour
On selecting PSLab MIC option before the In-Built MIC option, no popup stating if a PSLab device is not connected, when selecting In-Build MIC no activity can be seen on the monitor.

Expected Behaviour
The PSLab MIC option should be unable when then PSLab device is not connected.

Screenshots of the issue
Screenshot_20210120-125534_PSLab

Would you like to work on the issue?
Yes

@arpoch
Copy link
Author

arpoch commented Jan 22, 2021

If have applied the changes, and the code is working fine. So should I now make a PR, can any please guide me through the procedure as it's my first PR.

Screenshot_20210122-225917_PSLab

@asaikarthikeya
Copy link
Member

Good. Create a new branch and push the changes to that branch. Later make pull request to development branch .

@AsCress
Copy link
Contributor

AsCress commented May 26, 2024

Superseeded by #2421 and resolved by #2422.

@AsCress AsCress closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants