Visibility of PSLab-MIC button changes when PSLab device is not found #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…device is not found
asaikarthikeya
suggested changes
Jan 23, 2021
Thanks. I have made the changes you asked. Can you please tell what does 'No newline at the end of file' means and what changes should I make now ? |
There was a problem hiding this comment.
Reason -- Not exactly sure but as per my understanding Generally when working with git or other Linux distros , They add '\n' at the end of each line by default sometime the miss to add. In this case \n is missing .
Solution - open terminal in your project folder and the checkout to your branch then try git diff --ignore-all-space .Might solve give a try
|
That was a feature. Change is not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2173
Changes:
View.Gonewhen PSLab device is not found.Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-fdroid-debug.zip