Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #2190 At navigation drawer, The menu option of help & Report a … #2191

Closed
wants to merge 1 commit into from
Closed

fixed #2190 At navigation drawer, The menu option of help & Report a … #2191

wants to merge 1 commit into from

Conversation

Prashant830
Copy link

@Prashant830 Prashant830 commented Feb 4, 2021 •
edited

Fixes #2190

Changes:
added to menu option(report a bug & help) at navigation drawer.
Short Video/s for the changes: [Add screenshot/s of the layout where you made changes or a *.gif containing a demonstration]

WhatsApp.Video.2021-02-04.at.11.04.23.AM.mp4

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]

asaikarthikeya
asaikarthikeya reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@asaikarthikeya asaikarthikeya left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the general questions user may encounter are listed in FAQ section. And Report option is a part of Google play store rating IG .If we implement this way user is forced to create a gitter account and join the chat.We use gitter for developers support . Thank you.

@Prashant830
Copy link
Author

@asaikarthikeya I know but if someone finds a bug or issues then where will they report. Will you report in the issue folder of github repository yes or not, so I created the option of report or bug, which I have shared only the link with issue option of github repository and talked about, what we do in the help Is there any problem coming example, how to login, how to do it, then we ask for help, so I have added the gitter channel.

CodeWithSouma
CodeWithSouma reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@CodeWithSouma CodeWithSouma left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of the features already present in the about us section so I don't think it is necessary to add them in the navigation drawer.

@CloudyPadmal
Copy link
Collaborator

Nice work @Prashant830 and thanks for your effort on this feature. But I think we better keep it as it is since the drawer gets bit crowded with so many options.

@Prashant830
Copy link
Author

@CloudyPadmal OK, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeWithSouma CodeWithSouma CodeWithSouma left review comments

@asaikarthikeya asaikarthikeya asaikarthikeya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

At navigation drawer, The menu option of help & Report a Bug is missing ..
4 participants
@Prashant830 @CloudyPadmal @CodeWithSouma @asaikarthikeya