Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding handling to ActorSheetV2 for Actor#overrides #10886

Open
JPMeehan opened this issue May 10, 2024 · 3 comments
Open

Consider adding handling to ActorSheetV2 for Actor#overrides #10886

JPMeehan opened this issue May 10, 2024 · 3 comments
Labels
actors Issues related to Actors api Issues related to the API used by Mod Devs

Comments

@JPMeehan
Copy link

The Actor#overrides property is intended to track which fields have been altered by an AE and should not be passed back as part of a form submission update. I think there's two options for implementing this.

  1. Parity with ActorSheet: Strip overrides from the form submission handler
  2. ALSO disable any input fields with a name property in the keys of overrides

It's possible that this second feature would conflict with other rendering frameworks, since it's a DOM modification. Would probably be good to survey devs in the AppV2 thread regarding this.

@aaclayton aaclayton added api Issues related to the API used by Mod Devs actors Issues related to Actors labels May 11, 2024
@aaclayton aaclayton self-assigned this May 11, 2024
@aaclayton aaclayton modified the milestone: V12 User Testing 4 May 11, 2024
@aaclayton aaclayton removed their assignment May 16, 2024
@JPMeehan
Copy link
Author

@aaclayton I take it that this is not getting into v12 at all, then?

@aaclayton
Copy link
Contributor

aaclayton commented May 20, 2024

It's not going to make it. Will have to wait for V13 when we actually start converting actor sheets to ApplicationV2. Systems which want to early-adopt are welcome to lift-and-shift this code themselves or devise an alternative approach for defining which fields should be editable.

@JPMeehan
Copy link
Author

Okay. I got it working in Boilerplate so that at least will help anyone starting out on system development soon, same with DragDrop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actors Issues related to Actors api Issues related to the API used by Mod Devs
Projects
None yet
Development

No branches or pull requests

2 participants