Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Application that is rendering a ProseMirror editor to the parameters of relevant hooks #10895

Open
mclemente opened this issue May 12, 2024 · 1 comment
Open

Add the Application that is rendering a ProseMirror editor to the parameters of relevant hooks #10895

mclemente opened this issue May 12, 2024 · 1 comment
Labels
api Issues related to the API used by Mod Devs text-editor Issues related to the ProseMirror or legacy TinyMCE text editor

Comments

@mclemente
Copy link

User Experience

There is no way to tell which Application is rendering a ProseMirror editor on hooks such as getProseMirrorMenuItems and getProseMirrorMenuDropDowns.

My use-case is that I want to have a submenu to be shown on Journal Pages but not on Actor/Item Sheet.
@aaclayton
Copy link
Contributor

We can look into this, but I don't think we will spend time developing an ApplicationV1 solution to this since our codebase is moving towards ApplicationV2 and use of the custom HTML <prose-mirror> element which works a bit differently.

@aaclayton aaclayton added text-editor Issues related to the ProseMirror or legacy TinyMCE text editor api Issues related to the API used by Mod Devs labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Issues related to the API used by Mod Devs text-editor Issues related to the ProseMirror or legacy TinyMCE text editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaclayton @mclemente