Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added EffectsCanvasGroup#testInsideLight and EffectsCanvasGroup#testInsideDarkness #10917

Closed
dev7355608 opened this issue May 15, 2024 · 0 comments
Closed

Added EffectsCanvasGroup#testInsideLight and EffectsCanvasGroup#testInsideDarkness #10917

dev7355608 opened this issue May 15, 2024 · 0 comments
Assignees
@dev7355608
Labels
api Issues related to the API used by Mod Devs lighting/fog Issues related to dynamic lighting or fog of war vision Issues related to Token vision and vision modes
Milestone
V12 User Testing ...

Comments

@dev7355608
Copy link

dev7355608 commented May 15, 2024 •
edited

  • Move code inside DetectionMode#_testPoint (including DetectionMode#_testDarknessMeshes) to CanvasEffectsGroup#testInsideLight(point, elevation).
  • Move code inside PointLightSource##updateDarknessSuppression and PointVisionSource##updateBlindedState to CanvasEffectsGroup#testInsideDarkness(point, elevation).
@dev7355608 dev7355608 added lighting/fog Issues related to dynamic lighting or fog of war api Issues related to the API used by Mod Devs vision Issues related to Token vision and vision modes labels May 15, 2024
@dev7355608 dev7355608 added this to the V12 User Testing 4 milestone May 15, 2024
@dev7355608 dev7355608 self-assigned this May 15, 2024
@dev7355608 dev7355608 changed the title Add darkness and light containment test functions to CanvasEffectsGroup Added EffectsCanvasGroup#testInsideLight and EffectsCanvasGroup#testInsideDarkness May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dev7355608 dev7355608

Labels
api Issues related to the API used by Mod Devs lighting/fog Issues related to dynamic lighting or fog of war vision Issues related to Token vision and vision modes
Projects
Foundry VTT - Version 12
Status: Done
Milestone
V12 User Testing 4 - 12.323
Development

No branches or pull requests
2 participants
@aaclayton @dev7355608