Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way that DataModel#updateSource for dryRun: true updates to instead capture and operate on a clone of the data model to avoid a number of edge cases related to handling of dry run backups and validation of dry-run changes. #10922

Open
dev7355608 opened this issue May 15, 2024 · 0 comments
Assignees
Labels
bug Functionality which is not working as intended data-models Issues related to data models and schema changes

Comments

@dev7355608
Copy link

dev7355608 commented May 15, 2024

Example Use Case

Failed joint validation does not prevent Toggle Behavior from being persisted

Reproduction:

  1. Create a Region and add a Toggle Behavior behavior.
  2. Add the same Region Behavior UUID to both Enable Behaviors and Disable Behaviors.
  3. Click Update.
  4. Joint validation error pops up.
  5. Click Update again.
  6. No joint validation error this time. The update is committed to the database. After reloading the behavior ends up in the set of invalid documents.
@dev7355608 dev7355608 added bug Functionality which is not working as intended data-models Issues related to data models and schema changes labels May 15, 2024
@dev7355608 dev7355608 added this to the V12 User Testing 4 milestone May 15, 2024
@aaclayton aaclayton removed this from the V12 User Testing 4 milestone May 15, 2024
@Fyorl Fyorl assigned Fyorl and unassigned Fyorl May 16, 2024
@aaclayton aaclayton self-assigned this May 20, 2024
@aaclayton aaclayton changed the title Failed joint validation does not prevent Toggle Behavior from being persisted Change the way that DataModel#updateSource for dryRun: true updates to instead capture and operate on a clone of the data model to avoid a number of edge cases related to handling of dry run backups and validation of dry-run changes. May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended data-models Issues related to data models and schema changes
Projects
None yet
Development

No branches or pull requests

3 participants