Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambience filter effects are not applied to the background color of the Scene #10927

Closed
2 of 6 tasks
CarlosFdez opened this issue May 15, 2024 · 5 comments
Closed
2 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. lighting/fog Issues related to dynamic lighting or fog of war

Comments

@CarlosFdez
Copy link

CarlosFdez commented May 15, 2024

What happened?

The purple token tinting is incredibly powerful to the point where we had to reduce dark scene luminosity in preCreate (to 0, but now I'm considering -0.25) because people thought it was a bug. Reset to defaults unfortunately foils that plan though, because the defaults are hardcoded.

image

A closer look
image

Something to consider though is how it looks on a real map. For example alaustin in in the discord posted this example. Undoing the tint on just the tokens will look like weird behavior. The actual solution is beyond me, but perhaps altering the default works well as a short term bandaid?
Foundry_Virtual_Tabletop_RkxbWwYEC3-1

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Make a new scene, then transition it to darkness. Create a new actor and place on the scene. Create a new light source and place on the scene.

What core version are you reporting this for?

12.322

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@CarlosFdez CarlosFdez added the bug Functionality which is not working as intended label May 15, 2024
@aaclayton
Copy link
Contributor

we had to reduce dark scene luminosity in preCreate (to 0, but now I'm considering -0.25)

I think the visual phenomenon you are commenting on here is more related to hue intensity rather than luminosity.

@aaclayton aaclayton added lighting/fog Issues related to dynamic lighting or fog of war and removed bug Functionality which is not working as intended labels May 16, 2024
@CarlosFdez
Copy link
Author

The luminosity slider in the environmental dark settings seems to be what triggers this behavior. Reducing it to -0.25 from -0.5 renders mystery man in light visible again. It could be that hue intensity uses luminosity to compute the result though?

@dev7355608 dev7355608 self-assigned this May 17, 2024
@dev7355608 dev7355608 added bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. labels May 17, 2024
@dev7355608 dev7355608 changed the title Default Tokens are barely visible in well lit conditions in dark scenes Ambience filter effects are not applied to the background color of the Scene May 17, 2024
@dev7355608
Copy link

The issue is that the ambience filter effects are not applied to the background color of the scene. This is what it's supposed to look like:
image

@dev7355608 dev7355608 added this to the V12 User Testing 4 milestone May 17, 2024
@Norc
Copy link
Contributor

Norc commented May 17, 2024

To clarify, this issue was only occurring when no background image was set.

@CarlosFdez
Copy link
Author

CarlosFdez commented May 17, 2024

Ah, so there was a bug, we just didn't id it right! Tbh I wondered if this was the real issue, but I only vaguely suspected it and moved on. Awesome! Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. lighting/fog Issues related to dynamic lighting or fog of war
Projects
Status: Done
Development

No branches or pull requests

4 participants