Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentCollection#delete does not return a boolean #10936

Closed
JPMeehan opened this issue May 16, 2024 · 0 comments
Closed

DocumentCollection#delete does not return a boolean #10936

JPMeehan opened this issue May 16, 2024 · 0 comments
Assignees
@aaclayton
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended
Milestone
V12 Stable 1 - 12...

Comments

@JPMeehan
Copy link

DocumentCollection extends Collection which extends Map, and in the process overrides delete. Map#delete returns a boolean if the deletion was successful; DocumentCollection#delete returns nothing, violating inheritance.

Separate ticket from #10227 because this is an API issue rather than a mere type annotation.
@aaclayton aaclayton added bug Functionality which is not working as intended api Issues related to the API used by Mod Devs labels May 17, 2024
@aaclayton aaclayton self-assigned this May 20, 2024
@aaclayton aaclayton added this to the V12 Stable 1 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaclayton aaclayton

Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended
Projects
Foundry VTT - Version 12
Status: Done
Milestone
V12 Stable 1 - 12.324
Development

No branches or pull requests
2 participants
@aaclayton @JPMeehan