-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use header request based user agent hints where available when generating support report #7750
Comments
It's possible this is because of an ongoing reduction of User Agent strings, which presumably Firefox would be adopting as well. Mac OS platform has been capped at 10.15.7 since Chrome 90. |
I'm not sure what we could/should do better here - if anyone has suggestions I'm open to them otherwise I think this is probably too low priority for us to focus on. |
I'm not sure what state User Agent Client Hints is in for the different browsers, but maybe migrating to that and using |
I don't normally like to ask others to do our homework, but for this particular issue I would ask someone with Mac hardware to do some exploration and let us know what options work best for detection. Anything I would do here would just be a shot in the dark unfortunately |
I just noticed a caveat with using UA CH headers: they're only available over secure connections/HTTPS. So I guess that's a bad choice for the Support tool. But per this site https://web.dev/migrate-to-ua-ch/ you should check
to get the platform and version. This works in Chrome and in the Electron app consoles when connected to the FVTT server. Where the current .userAgentData is notable not available in Safari or Firefox currently: https://caniuse.com/mdn-api_navigator_useragentdata |
Originally reported by rathlord https://discord.com/channels/170995199584108546/1065764070680186930/1157682125177368586 ALL MODULES DISABLED? Yes/NA |
I think this is high priority to try and address before V12 stable so we have actionable information in our support report. |
What happened?
The
Support
reporting tool currently fails to identify modern Mac hardware/OS combos, in both Chromium/Electron and Firefox.On an M1 Mac running macOS 12.5, this is the Chromium report:
and this is the Firefox report:
I know we're up against whatever the browsers are providing for useragent strings, but it would be nice if we could find an alternate heuristic perhaps. This is certainly small-potatoes, but figured it was worth noting for the record.
What ways of accessing Foundry can you encounter this issue in?
Reproduction Steps
Support Details
screen from an M1 Mac.What core version are you reporting this for?
Version 10 Testing 3 (build 277)
Relevant log output
No response
Bug Checklist
The text was updated successfully, but these errors were encountered: