feat(cli): allow unrecognized encoding #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkalt
reviewed
Mar 14, 2023
| if !ok { | ||
| packageName := strings.Split(schema.Name, "/")[0] | ||
| transcoder, err = ros.NewJSONTranscoder(packageName, schema.Data) | ||
| if schema == nil || schema.Encoding == "" { |
There was a problem hiding this comment.
@jon-chuang is the idea with this patch to split out the change for supporting nil schemas, from support for CBOR? It seems like it still depends on the CBOR change, so I don't understand how it's different from the other patch.
There was a problem hiding this comment.
Sorry, this PR is building on the previous patch. The main change is handling unrecognized encoding by writing the raw data bytes insted of throwing an error. I'll convert this to a draft, it should be clearer once that PR is merged.
|
Closing this PR due to lack of activity. If you revive these efforts we can revisit this or other PRs. Thanks for doing the research and proposing these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Description
One can now see raw bytes of messages from
mcap cat --jsonalong with the metadataComments:
cat --json#848 to be merged firstFix: #817