Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular semver dependency in npm run build #380

Closed
tcompa opened this issue Dec 19, 2023 · 1 comment · Fixed by #379
Closed

Circular semver dependency in npm run build #380

tcompa opened this issue Dec 19, 2023 · 1 comment · Fixed by #379
Labels
low hanging fruit Expected to be an easy fix

Comments

@tcompa
Copy link
Collaborator

tcompa commented Dec 19, 2023

$ npm run build

[...]

> Using @sveltejs/adapter-node
Circular dependency: node_modules/semver/classes/comparator.js -> node_modules/semver/classes/range.js -> node_modules/semver/classes/comparator.js

This is an issue which exists upstream:

If a change like this one also works for us, great. If not, we can close this issue - but at least we'll find it when we are puzzled by the same message in the future.

@tcompa tcompa added the low hanging fruit Expected to be an easy fix label Dec 20, 2023
@zonia3000
Copy link
Collaborator

I confirm that, as mentioned in one of the referenced issues, importing the single functions instead of the entire module resolves the problem. Fixed in 50b2a27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low hanging fruit Expected to be an easy fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants