Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] typo in framer docs #1564

Closed
tahseenio opened this issue Jun 2, 2022 · 2 comments
Closed

[BUG] typo in framer docs #1564

tahseenio opened this issue Jun 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@tahseenio
Copy link

tahseenio commented Jun 2, 2022

1. Read the FAQs 馃憞

2. Describe the bug
Typo in close-source docs website.
So the issue is a small typo in https://www.framer.com/docs/examples/ , 'Shared layout animations'. and https://www.framer.com/docs/animation/ , in the 'Shared layout animations'. The sample code is not the same.

Give a clear and concise description of what the bug is.

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug
Unable to due to closed-source

A CodeSandbox minimal reproduction will allow us to quickly follow the reproduction steps. Without one, this bug report won't be accepted.

4. Steps to reproduce

Steps to reproduce the behavior:

  1. Go to the Shared layout animations at https://www.framer.com/docs/examples/ . You will see the sample code is isSelected ? <motion.div layoutId="underline" /> : null
  2. Go to the Shared layout animations at https://www.framer.com/docs/animation/ . You will see the sample code is isSelected && <motion.div layoutId="underline" /> : null

5. Expected behavior
It is expected the ternary statement looks like the below.

  1. isSelected && <motion.div layoutId="underline" />
    or
  2. isSelected ? <motion.div layoutId="underline" /> : null

A clear and concise description of what you expected to happen.

6. Video or screenshots

If applicable, add a video or screenshots to help explain the bug.

7. Environment details

If applicable, let us know which OS, browser, browser version etc you're using.

@tahseenio tahseenio added the bug Something isn't working label Jun 2, 2022
@tahseenio tahseenio changed the title [BUG] [BUG] typo in framer docs Jun 2, 2022
@tahseenio
Copy link
Author

I have sent this information to Palmaswell#6348 ( framer-staff ) in the Framer discord who will File a report internally and get this fixed.

@mattgperry
Copy link
Collaborator

A fix for this went out yesterday, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants