Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent ordering behavior between versions #2347

Closed
AlbinAxtelius opened this issue Sep 25, 2023 · 1 comment
Closed

[BUG] Inconsistent ordering behavior between versions #2347

AlbinAxtelius opened this issue Sep 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AlbinAxtelius
Copy link

1. Read the FAQs 馃憞

2. Describe the bug

Inconsistent behavior between ordering items in the Reorder component. It works as expected on version 10.9.4 but I get some problems with ordering on version 10.16.4. I haven't looked through different versions to see where it starts.

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug

https://codesandbox.io/s/framermotionbugreport-forked-w4sk78

4. Steps to reproduce

Steps to reproduce the behavior:

  1. Reorder an item and move it to a different slot
  2. Reorder another item and the problem should be there

5. Expected behavior

Version 10.16.4 should work the same as in 10.9.4

6. Video or screenshots

Screen.Recording.2023-09-25.at.11.29.52.mov

7. Environment details

If applicable, let us know which OS, browser, browser version etc you're using.

FAQs

Framer Motion won't install

Framer Motion 7+ uses React 18 as a minimum. If you can't upgrade React, install the latest version of Framer Motion 6.

height: "auto" is jumping

Animating to/from auto requires measuring the DOM. There's no perfect way to do this and if you have also applied padding to the same element, these measurements might be wrong.

The recommended solution is to move padding to a child element. See this issue for the full discussion.

Type error with AnimateSharedLayout

AnimateSharedLayout was deprecated in 5.0. Refer to the upgrade guide for instructions on how to remove.

Preact isn't working

Framer Motion isn't compatible with Preact.

AnimatePresence isn't working

Have all of its immediate children got a unique key prop that remains the same for that component every render?

// Bad: The index could be given to a different component if the order of items changes
<AnimatePresence>
  {items.map((item, index) => <Component key={index} />)}
</AnimatePresence>
// Good: The item ID is unique to each component
<AnimatePresence>
  {items.map((item, index) => <Component key={item.id} />)}
</AnimatePresence>

Is the AnimatePresence correctly outside of the controlling conditional? AnimatePresence must be rendered whenever you expect an exit animation to run - it can't do so if it's unmounted!

// Bad: AnimatePresence is unmounted - exit animations won't run
{isVisible && (
  <AnimatePresence>
    <Component />
  </AnimatePresence>
)}
// Good: Only the children are unmounted - exit animations will run
<AnimatePresence>
  {isVisible && <Component />}
</AnimatePresence>
@AlbinAxtelius AlbinAxtelius added the bug Something isn't working label Sep 25, 2023
@mattgperry
Copy link
Collaborator

As this broke in version 10.12.8 - folding into #2476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants