Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export UseScrollOptions interface #2522

Open
Jwelliver opened this issue Feb 21, 2024 · 0 comments · May be fixed by #2523
Open

Export UseScrollOptions interface #2522

Jwelliver opened this issue Feb 21, 2024 · 0 comments · May be fixed by #2523
Labels
feature New feature or request

Comments

@Jwelliver
Copy link

Is your feature request related to a problem? Please describe.
I am building a wrapper hook which implements the useScroll and useInView hooks. My custom hook accepts the parameters for each of those hooks. While the UseInViewOptions interface is exposed, UseScrollOptions is not.

I believe it would be beneficial to those using Typescript to have access to the UseScrollOptions interface. This change would also increase consistency with an established pattern, such as with useInView and UseInViewOptions.

Describe the solution you'd like
Include the UseScrollOptions interface in exports.

I'd like to make a contribution to add this export and will create a pull request.

@Jwelliver Jwelliver added the feature New feature or request label Feb 21, 2024
@Jwelliver Jwelliver linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant