Adds an unmount check to AnimatePresence prior to animation exit callback #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting issues in my jest tests without this, due to state updates occurring on an unmounted component. My component under test had an exit animation that completed post unmount of the parent component.
I also fixed the tests that were causing console.error logs. Refactored them to use the "async act" test util. IMO, the existing tests need a few more cleanup / refactor rounds to utilize this same strategy. Unfortunately I don't have the capacity to help with that right now. I did at least refactor the tests that were producing console.error logs. 👍