Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsiveVariants to ignoredKeys by default #336

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sushi-chaaaan
Copy link

@sushi-chaaaan sushi-chaaaan commented Apr 27, 2024

Add responsiveVariants to ignoredKeys by default

Description

Currently, compoundVariants and defaultVariants are set by default for ignoredKeys, but tailwind-variants has other responsiveVariants.
Thinking this plugin has tv by default in callees, this should not be Warned either, so I added responsiveVariants to default ignoredKeys.

Fixes #323

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • 2 unit tests in tests/lib/rules/no-custom-classname

Test Configuration:

  • OS + version: WSL2 Ubuntu 22.04 in Windows 11
  • NPM version: 10.2.5
  • Node version: 21.6.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] add responsiveVariants to ignoredKeys by default
1 participant