Update dependencies #130
Closed
Update dependencies #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 38 38
Lines 5323 5323
=======================================
Hits 5321 5321
Misses 1 1
Partials 1 1Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128
As said in the issue,
git.apache.org/thrift.githas moved togithub.com/apache/thriftand some indirect dependency still used it. I didn't find which one it was, but after updating dependencies, the problem is gone + I've run "go mod tidy" and a lot of dependencies are not needed anymore, which is good.